London| 26-ITP-Sep |Vaibhav Patel| Sprint 1 | Form control - #1490
Open
vibhu9407 wants to merge 1 commit into
Open
London| 26-ITP-Sep |Vaibhav Patel| Sprint 1 | Form control#1490vibhu9407 wants to merge 1 commit into
vibhu9407 wants to merge 1 commit into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
vibhu9407
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
vibhu9407
changed the title
vibhu9407
changed the title
vibhu9407
added
the
Needs Review
cjyuan
reviewed
Sep 13, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Do i have to create submit button or it is fine as i did?
Yes. You should.
Comment on lines
+26
to
+28
| <div> | ||
| <label for="email">Email:</label> | ||
| <input |
Contributor
There was a problem hiding this comment.
Indentation is off.
Suggestion:
- Look up the benefits of using a code formatter.
- Install the Prettier extension for VS Code, then:
- Use VS Code's Format Document feature to format your code.
- Optionally, enable Format On Save and Format On Paste to keep your code consistently formatted.
Resource: Visual Studio Code - Formatting
Note: The formatter may not work correctly if your code contains syntax errors.
Comment on lines
+56
to
59
| <!-- write your html here--> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> |
Contributor
There was a problem hiding this comment.
If the comments are no longer needed, you could delete them to keep the code clean.
Comment on lines
+18
to
+21
| <input | ||
| type="text" | ||
| id="name" | ||
| name="name" |
Contributor
There was a problem hiding this comment.
Chrome's "Developer tools" identified this possible improvement:
Comment on lines
+36
to
+45
| <label for="color">T-shirt color:</label> | ||
| <select id="color" name="color" required> | ||
| <option value="">Please choose a color</option> | ||
| <option value="Black">Black</option> | ||
| <option value="White">White</option> | ||
| <option value="Blue">Blue</option> | ||
| </select> | ||
| </div> | ||
| <div> | ||
| <label for="size">T-shirt Size:</label> |
Contributor
There was a problem hiding this comment.
Could you spot a minor inconsistency between these two labels?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1004
Changelist
Questions
Do i have to create submit button or it is fine as i did?